(groovy) branch master updated: Trivial refactor: replace `StringBuilder` with `String`

[sunlan]

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new bf14e4ffbb Trivial refactor: replace `StringBuilder` with `String`
bf14e4ffbb is described below

commit bf14e4ffbbf8cf40257ff2b3e6b677262f346d0c
Author: Daniel Sun <sun...@apache.org>
AuthorDate: Sat Jul 5 01:12:33 2025 +0900

    Trivial refactor: replace `StringBuilder` with `String`
---
 src/main/java/groovy/lang/TracingInterceptor.java                   | 6 ++----
 src/main/java/org/apache/groovy/ast/tools/ClassNodeUtils.java       | 6 ++----
 src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java  | 6 ++----
 .../groovy/console/ui/text/StructuredSyntaxDocumentFilter.java      | 6 ++----
 4 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/src/main/java/groovy/lang/TracingInterceptor.java 
b/src/main/java/groovy/lang/TracingInterceptor.java
index e4a266ae34..b4210b67f0 100644
--- a/src/main/java/groovy/lang/TracingInterceptor.java
+++ b/src/main/java/groovy/lang/TracingInterceptor.java
@@ -108,9 +108,7 @@ public class TracingInterceptor implements Interceptor {
         String argumentTypes = java.util.stream.Stream.of(arguments)
                 .map(arg -> arg != null ? arg.getClass().getName() : 
"java.lang.Object") // GROOVY-10009
                 .collect(java.util.stream.Collectors.joining(", "));
-        StringBuilder result = new StringBuilder(aClass.getName());
-        result.append('.').append(methodName).append('(');
-        result.append(argumentTypes).append(')');
-        writer.write(result.toString());
+        String result = aClass.getName() + '.' + methodName + '(' + 
argumentTypes + ')';
+        writer.write(result);
     }
 }
diff --git a/src/main/java/org/apache/groovy/ast/tools/ClassNodeUtils.java 
b/src/main/java/org/apache/groovy/ast/tools/ClassNodeUtils.java
index b16fae4603..cd67d9849f 100644
--- a/src/main/java/org/apache/groovy/ast/tools/ClassNodeUtils.java
+++ b/src/main/java/org/apache/groovy/ast/tools/ClassNodeUtils.java
@@ -81,10 +81,8 @@ public class ClassNodeUtils {
                 dim += 1;
                 cn = cn.getComponentType();
             }
-            StringBuilder sb = new StringBuilder(cn.getName().length() + (2 * 
dim));
-            sb.append(formatTypeName(cn));
-            sb.append("[]".repeat(dim));
-            return sb.toString();
+            String sb = formatTypeName(cn) + "[]".repeat(dim);
+            return sb;
         }
         return cNode.isGenericsPlaceHolder() ? cNode.getUnresolvedName() : 
cNode.getName();
     }
diff --git a/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java 
b/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java
index 1ebf8d495a..e46ba8b1ec 100644
--- a/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java
+++ b/src/main/java/org/codehaus/groovy/classgen/asm/CallSiteWriter.java
@@ -77,10 +77,8 @@ public class CallSiteWriter {
                         SIG_ARRAY_LENGTH, numberOfArguments));
         }
         if (sig[numberOfArguments] == null) {
-            StringBuilder sb = new StringBuilder("(");
-            sb.append("Ljava/lang/Object;".repeat(numberOfArguments));
-            sb.append(")[Ljava/lang/Object;");
-            sig[numberOfArguments] = sb.toString();
+            String sb = "(" + "Ljava/lang/Object;".repeat(numberOfArguments) + 
")[Ljava/lang/Object;";
+            sig[numberOfArguments] = sb;
         }
         return sig[numberOfArguments];
     }
diff --git 
a/subprojects/groovy-console/src/main/groovy/groovy/console/ui/text/StructuredSyntaxDocumentFilter.java
 
b/subprojects/groovy-console/src/main/groovy/groovy/console/ui/text/StructuredSyntaxDocumentFilter.java
index a9511805a6..9437c87a45 100644
--- 
a/subprojects/groovy-console/src/main/groovy/groovy/console/ui/text/StructuredSyntaxDocumentFilter.java
+++ 
b/subprojects/groovy-console/src/main/groovy/groovy/console/ui/text/StructuredSyntaxDocumentFilter.java
@@ -68,10 +68,8 @@ public class StructuredSyntaxDocumentFilter extends 
DocumentFilter {
         String checking = regexp.replace("\\(", "X").replace("(?", "X");
         int checked = checking.indexOf('(');
         if (checked > -1) {
-            StringBuilder msg = new StringBuilder("Only non-capturing groups 
allowed:\r\n" + regexp + "\r\n");
-            msg.append(" ".repeat(checked));
-            msg.append("^");
-            throw new IllegalArgumentException(msg.toString());
+            String msg = "Only non-capturing groups allowed:\r\n" + regexp + 
"\r\n" + " ".repeat(checked) + "^";
+            throw new IllegalArgumentException(msg);
         }
     }