Copilot commented on code in PR #10974: URL: https://github.com/apache/gravitino/pull/10974#discussion_r3190435931
########## authenticators/authenticator-basic/src/main/java/org/apache/gravitino/auth/local/password/Argon2idPasswordHasher.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.auth.local.password; + +import com.google.common.base.Preconditions; +import de.mkammerer.argon2.Argon2; +import de.mkammerer.argon2.Argon2Factory; +import org.apache.commons.lang3.StringUtils; + +/** Argon2id-based password hasher. */ +public class Argon2idPasswordHasher implements PasswordHasher { + + private static final int ITERATIONS = 3; + private static final int MEMORY_KB = 1 << 16; + private static final int PARALLELISM = 1; + + @Override + public String hash(String plainPassword) { + Preconditions.checkArgument( + StringUtils.isNotBlank(plainPassword), "Plain password must not be blank"); + + Argon2 argon2 = Argon2Factory.create(Argon2Factory.Argon2Types.ARGON2id); + char[] passwordChars = plainPassword.toCharArray(); + try { + return argon2.hash(ITERATIONS, MEMORY_KB, PARALLELISM, passwordChars); + } finally { + argon2.wipeArray(passwordChars); + } Review Comment: The `Argon2` instance created via `Argon2Factory.create(...)` is never closed. In argon2-jvm this can retain native resources and lead to memory/resource leaks under load. Use try-with-resources (or explicitly call `argon2.close()` in `finally`) so the hasher releases resources after hashing/verifying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
