polyzos commented on PR #10442: URL: https://github.com/apache/gravitino/pull/10442#issuecomment-4364436383
@jerryshao @FANNG1 Nice work here. The flink-common + versioned modules layout and the CatalogCompat hook are the right foundation. Two direction-level thoughts: Version target: Flink 2.2 has been GA since December 2025. Supporting 1.18-1.20 now risks doing this refactor twice. Worth considering dropping 1.18 in favor of 2.x, or at least sketching how CatalogCompatibility extends to 2.x so today’s choices stay forward-compatible. Baseline: compiling flink-common against 1.18 locks in references to APIs 2.x removed (SinkFunction, legacy TableSource/TableSink, the old config parser). Picking 1.20 LTS as the baseline keeps shared code 2.x-ready · the 1.18 module carries downward backports instead, which is a smaller surface. A good reference is Apache Fluss and how it manages this and do something similar https://github.com/apache/fluss/tree/main/fluss-flink -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
