laserninja commented on PR #10757: URL: https://github.com/apache/gravitino/pull/10757#issuecomment-4353703883
Pushed 426161814: reverted tpch/catalog_iceberg_prepare.sql to the original explicit CREATE TABLE + INSERT INTO ... SELECT * pattern. Root cause: switching that script to CREATE TABLE ... AS SELECT * FROM tpch.tiny.* failed because the TPC-H connector exposes columns as VARCHAR(N), and IcebergDataTypeTransformer rejects length-bounded VARCHAR (Iceberg does not support the datatype VARCHAR with length). The previous form sidesteps this by declaring unbounded varchar columns up front and letting INSERT cast. CTAS coverage stays in 00013_ctas.sql, so the TPC-H prep doesn't need to also demonstrate CTAS. Also, his surfaces a separate limitation: CTAS into Iceberg from any source with bounded VARCHAR currently fails. Happy to file a follow-up issue to relax IcebergDataTypeTransformer to accept VARCHAR(N) and map it to unbounded, but it feels out of scope for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
