yuqi1129 commented on code in PR #10912: URL: https://github.com/apache/gravitino/pull/10912#discussion_r3167700932
########## scripts/h2/schema-1.3.0-h2.sql: ########## @@ -560,3 +565,15 @@ CREATE INDEX IF NOT EXISTS `idx_table_metrics_composite` ON `table_metrics`(`table_identifier`, `table_partition`, `metric_ts`); CREATE INDEX IF NOT EXISTS `idx_job_metrics_identifier_metric_ts` ON `job_metrics`(`job_identifier`, `metric_ts`); + +CREATE TABLE IF NOT EXISTS `entity_change_log` ( + `id` BIGINT UNSIGNED NOT NULL AUTO_INCREMENT, + `metalake_name` VARCHAR(128) NOT NULL, + `entity_type` VARCHAR(32) NOT NULL, + `full_name` VARCHAR(512) NOT NULL, Review Comment: This is the change log, and it's okay to store the name. Using ID will make us query the database to get the names, so I'm relunctant to use ID here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
