roryqi commented on PR #10908: URL: https://github.com/apache/gravitino/pull/10908#issuecomment-4350650477
> > > > It seems that we can't remove Jcasbin, can we > > > > > > > > > What do you mean here? > > > > > > The PR seems to do the duplicated with Jcasbin's function. If we follow the style of this pull request, we should implement check logic instead of using Jcasbin. > > I agree on the point that this change is duplicated with JCasbin's internal function to some extent. It replaces Jasbin's low-quality authorization method and tries to use the map to optimize the auth logic. > > This is just an improvement for a specific method, and Jcasbin still plays a key role in expression analysis, group, and grant management. > > Still, we need to thoroughly look into the JCasbin framework and try to optimize it one by one. If you have a good idea, please do not hesitate to raise it. We can only use expression layer. We can implement our enforcer from your pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
