jerryshao commented on code in PR #10908:
URL: https://github.com/apache/gravitino/pull/10908#discussion_r3165595505
##########
server-common/src/main/java/org/apache/gravitino/server/authorization/jcasbin/JcasbinAuthorizer.java:
##########
@@ -407,10 +423,12 @@ public void close() throws IOException {
private class InternalAuthorizer {
- Enforcer enforcer;
+ private final Enforcer enforcer;
+ private final boolean denyMode;
- public InternalAuthorizer(Enforcer enforcer) {
+ InternalAuthorizer(Enforcer enforcer, boolean denyMode) {
Review Comment:
Using `true` or `false` for different constructors is not so clear for the
reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
