roryqi commented on code in PR #10874:
URL: https://github.com/apache/gravitino/pull/10874#discussion_r3161111480
##########
server-common/src/main/java/org/apache/gravitino/server/authorization/jcasbin/JcasbinAuthorizer.java:
##########
@@ -222,15 +224,31 @@ public boolean isOwner(
String metalake,
MetadataObject metadataObject,
AuthorizationRequestContext requestContext) {
- boolean result;
- try {
+ boolean result = false;
+ if (metadataObject == null) {
+ return false;
+ }
+
+ if (metadataObject.type() == MetadataObject.Type.SCHEMA) {
+ for (MetadataObject scopeObject :
buildSchemaInheritanceChain(metadataObject)) {
+ Long metadataId = MetadataIdConverter.getID(scopeObject, metalake);
+ if (metadataId == null) {
+ continue;
+ }
+ loadOwnerPolicy(metalake, scopeObject, metadataId);
+ if (checkOwnership(principal, metalake, metadataId)) {
+ result = true;
+ break;
+ }
+ }
+ } else {
Long metadataId = MetadataIdConverter.getID(metadataObject, metalake);
- loadOwnerPolicy(metalake, metadataObject, metadataId);
- result = checkOwnership(principal, metalake, metadataId);
- } catch (Exception e) {
- LOG.debug("Can not get entity id", e);
- result = false;
+ if (metadataId != null) {
+ loadOwnerPolicy(metalake, metadataObject, metadataId);
+ result = checkOwnership(principal, metalake, metadataId);
+ }
}
Review Comment:
This meets expectation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
