mehakmeet commented on code in PR #10834:
URL: https://github.com/apache/gravitino/pull/10834#discussion_r3137485290
##########
core/src/main/java/org/apache/gravitino/hook/MetalakeHookDispatcher.java:
##########
@@ -71,14 +74,18 @@ public Metalake createMetalake(
accessControlDispatcher.addUser(ident.name(),
PrincipalUtils.getCurrentUserName());
}
Review Comment:
Yea, addUser seemed like a different type of exception so I let it be.
We have 2 cases of exception `UserAlreadyExistsException` then we can let
the setOwner call be as is, other exceptions means the user wasn't able to be
added to the metalake so setOwner will fail regardless, we can raise a warning
here too and return. User can be added afterwards as well since the metalake
creation has already happened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
