sunyuhan1998 commented on PR #10791: URL: https://github.com/apache/gravitino/pull/10791#issuecomment-4311318565
Hi @mchades, I've addressed the review comments from Copilot: 1. Removed the unused `_ConcreteGVFSOperations` class. 2. Added `test_mixed_credentials_cache_expiry_based_on_expiring_one` to cover the mixed credential scenario (never-expire + expiring), verifying that cache expiry is driven by the expiring credential. The other 4 suggestions were replied to inline — they don't need changes in this PR (detailed reasoning in each reply). Could you please take another look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
