tsungchih commented on code in PR #8692:
URL: https://github.com/apache/gravitino/pull/8692#discussion_r3131610022
##########
clients/client-python/gravitino/exceptions/base.py:
##########
@@ -205,6 +205,14 @@ class ForbiddenException(GravitinoRuntimeException):
"""An exception thrown when a user is forbidden to perform an action."""
+class IllegalStatisticNameException(IllegalArgumentException):
+ """An exception thrown when statistic has an illegal name"""
+
+
+class UnmodifiableStatisticException(UnsupportedOperationException):
+ """An exception thrown when users modify an unmodifiable statistic"""
Review Comment:
fixed
##########
clients/client-python/gravitino/api/stats/statistic.py:
##########
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+from abc import ABC, abstractmethod
+from typing import Any, Final
+
+from gravitino.api.auditable import Auditable
+from gravitino.api.stats.statistic_value import StatisticValue
+
+
+class Statistic(Auditable, ABC):
+ """Statistic interface represents a statistic that can be associated with
a metadata object.
+
+ It can be used to store various types of statistics, for example, table
statistics, partition
+ statistics, fileset statistics, etc.
+ """
+
+ CUSTOM_PREFIX: Final[str] = "custom-"
+ """The prefix for custom statistics. Custom statistics are user-defined
statistics."""
+
+ @abstractmethod
+ def name(self) -> str:
+ """Get the name of the statistic.
+
+ Returns:
+ str: the name of the statistic
+ """
+
+ @abstractmethod
+ def value(self) -> StatisticValue[Any] | None:
+ """Get the value of the statistic.
+
+ he value is optional. If the statistic is not set, the value will be
empty.
+
+ Returns:
+ StatisticValue:
+ An optional containing the value of the statistic if it is
set, otherwise empty.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
