roryqi commented on PR #10818:
URL: https://github.com/apache/gravitino/pull/10818#issuecomment-4301381765

   > It could be reproduced by running testcases added in 
`clients/client-java/src/test/java/org/apache/gravitino/client/TestHTTPClient.java`
 at `main` branch.
   > 
   > * `testSchemaErrorHandlerReturnsUnauthorizedForEmptyBody`
   > 
   > ```json
   > Unable to process: Error code: 401, error message: No content to map due 
to end-of-input
   >  at [Source: (String)""; line: 1, column: 0], json string: 
   > org.apache.gravitino.exceptions.RESTException: Unable to process: Error 
code: 401, error message: No content to map due to end-of-input
   >  at [Source: (String)""; line: 1, column: 0], json string: 
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$RestErrorHandler.accept(ErrorHandlers.java:1314)
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$SchemaErrorHandler.accept(ErrorHandlers.java:478)
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$SchemaErrorHandler.accept(ErrorHandlers.java:428)
   >    at 
app//org.apache.gravitino.client.HTTPClient.throwFailure(HTTPClient.java:236)
   >    at 
app//org.apache.gravitino.client.HTTPClient.execute(HTTPClient.java:388)
   >    at 
app//org.apache.gravitino.client.HTTPClient.execute(HTTPClient.java:296)
   >    at app//org.apache.gravitino.client.HTTPClient.get(HTTPClient.java:465)
   >    at app//org.apache.gravitino.client.RESTClient.get(RESTClient.java:165)
   >    at 
app//org.apache.gravitino.client.TestHTTPClient.lambda$testSchemaErrorHandlerReturnsUnauthorizedForEmptyBody$0(TestHTTPClient.java:239)
   >    at 
app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:55)
   >    at 
app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:37)
   >    at 
app//org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:3082)
   >    at 
app//org.apache.gravitino.client.TestHTTPClient.testSchemaErrorHandlerReturnsUnauthorizedForEmptyBody(TestHTTPClient.java:236)
   > ```
   > 
   > * `testSchemaErrorHandlerReturnsUnauthorizedForMissingBody`
   > 
   > ```json
   > Unable to process: Error code: 401, error message: No content to map due 
to end-of-input
   >  at [Source: (String)""; line: 1, column: 0], json string: 
   > org.apache.gravitino.exceptions.RESTException: Unable to process: Error 
code: 401, error message: No content to map due to end-of-input
   >  at [Source: (String)""; line: 1, column: 0], json string: 
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$RestErrorHandler.accept(ErrorHandlers.java:1314)
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$SchemaErrorHandler.accept(ErrorHandlers.java:478)
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$SchemaErrorHandler.accept(ErrorHandlers.java:428)
   >    at 
app//org.apache.gravitino.client.HTTPClient.throwFailure(HTTPClient.java:236)
   >    at 
app//org.apache.gravitino.client.HTTPClient.execute(HTTPClient.java:388)
   >    at 
app//org.apache.gravitino.client.HTTPClient.execute(HTTPClient.java:296)
   >    at app//org.apache.gravitino.client.HTTPClient.get(HTTPClient.java:465)
   >    at app//org.apache.gravitino.client.RESTClient.get(RESTClient.java:165)
   >    at 
app//org.apache.gravitino.client.TestHTTPClient.lambda$testSchemaErrorHandlerReturnsUnauthorizedForMissingBody$1(TestHTTPClient.java:256)
   >    at 
app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:55)
   >    at 
app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:37)
   >    at 
app//org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:3082)
   >    at 
app//org.apache.gravitino.client.TestHTTPClient.testSchemaErrorHandlerReturnsUnauthorizedForMissingBody(TestHTTPClient.java:253)
   > ```
   > 
   > * `testSchemaErrorHandlerReturnsUnauthorizedForNonJsonBody`
   > 
   > ```json
   > Unable to process: Error code: 401, error message: Unrecognized token 
'unauthorized': was expecting (JSON String, Number, Array, Object or token 
'null', 'true' or 'false')
   >  at [Source: (String)"unauthorized"; line: 1, column: 13], json string: 
unauthorized
   > org.apache.gravitino.exceptions.RESTException: Unable to process: Error 
code: 401, error message: Unrecognized token 'unauthorized': was expecting 
(JSON String, Number, Array, Object or token 'null', 'true' or 'false')
   >  at [Source: (String)"unauthorized"; line: 1, column: 13], json string: 
unauthorized
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$RestErrorHandler.accept(ErrorHandlers.java:1314)
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$SchemaErrorHandler.accept(ErrorHandlers.java:478)
   >    at 
app//org.apache.gravitino.client.ErrorHandlers$SchemaErrorHandler.accept(ErrorHandlers.java:428)
   >    at 
app//org.apache.gravitino.client.HTTPClient.throwFailure(HTTPClient.java:236)
   >    at 
app//org.apache.gravitino.client.HTTPClient.execute(HTTPClient.java:388)
   >    at 
app//org.apache.gravitino.client.HTTPClient.execute(HTTPClient.java:296)
   >    at app//org.apache.gravitino.client.HTTPClient.get(HTTPClient.java:465)
   >    at app//org.apache.gravitino.client.RESTClient.get(RESTClient.java:165)
   >    at 
app//org.apache.gravitino.client.TestHTTPClient.lambda$testSchemaErrorHandlerReturnsUnauthorizedForNonJsonBody$2(TestHTTPClient.java:273)
   >    at 
app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:55)
   >    at 
app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:37)
   >    at 
app//org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:3082)
   >    at 
app//org.apache.gravitino.client.TestHTTPClient.testSchemaErrorHandlerReturnsUnauthorizedForNonJsonBody(TestHTTPClient.java:270)
   > ```
   
   Is it common way to change the format the error response? I have some 
concern about this point. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to