jerryshao commented on code in PR #10840:
URL: https://github.com/apache/gravitino/pull/10840#discussion_r3122983212
##########
server-common/src/main/java/org/apache/gravitino/server/ServerConfig.java:
##########
@@ -35,6 +35,15 @@ public class ServerConfig extends Config {
.checkValue(value -> value > 0,
ConfigConstants.POSITIVE_NUMBER_ERROR_MSG)
.createWithDefault(3 * 1000);
+ public static final ConfigEntry<Long> HEALTH_ENTITY_STORE_PROBE_TIMEOUT_MS =
+ new ConfigBuilder("gravitino.server.health.entityStore.probeTimeoutMs")
+ .doc(
+ "Timeout in milliseconds for the entity-store liveness probe
used by health endpoints")
+ .version(ConfigConstants.VERSION_1_3_0)
+ .longConf()
+ .checkValue(value -> value > 0,
ConfigConstants.POSITIVE_NUMBER_ERROR_MSG)
+ .createWithDefault(2000L);
Review Comment:
Fixed. Updated the doc string to read "entity-store readiness probe used by
/api/health/ready".
##########
server-common/src/main/java/org/apache/gravitino/server/ServerConfig.java:
##########
@@ -35,6 +35,15 @@ public class ServerConfig extends Config {
.checkValue(value -> value > 0,
ConfigConstants.POSITIVE_NUMBER_ERROR_MSG)
.createWithDefault(3 * 1000);
+ public static final ConfigEntry<Long> HEALTH_ENTITY_STORE_PROBE_TIMEOUT_MS =
+ new ConfigBuilder("gravitino.server.health.entityStore.probeTimeoutMs")
+ .doc(
+ "Timeout in milliseconds for the entity-store liveness probe
used by health endpoints")
+ .version(ConfigConstants.VERSION_1_3_0)
+ .longConf()
+ .checkValue(value -> value > 0,
ConfigConstants.POSITIVE_NUMBER_ERROR_MSG)
+ .createWithDefault(2000L);
Review Comment:
Acknowledged. The PR description's 'No property keys added or removed'
checkbox is incorrect — this PR does add
`gravitino.server.health.entityStore.probeTimeoutMs`. I will update the PR
description to reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
