Copilot commented on code in PR #10836:
URL: https://github.com/apache/gravitino/pull/10836#discussion_r3121036311
##########
.github/workflows/build.yml:
##########
@@ -6,15 +6,11 @@ on:
push:
branches: [ "main", "branch-*" ]
paths-ignore:
- - '**/*.md'
- - '**/*.mdx'
- 'docs/assets/**'
- 'web-v2/**'
pull_request:
branches: [ "main", "branch-*" ]
paths-ignore:
- - '**/*.md'
- - '**/*.mdx'
- 'docs/assets/**'
- 'web-v2/**'
Review Comment:
Removing `paths-ignore` for `**/*.md`/`**/*.mdx` makes the workflow trigger
on markdown changes, but the subsequent `dorny/paths-filter` configuration
still explicitly excludes `!**/*.md` and `!**/*.mdx` from `source_changes`. As
a result, markdown-only PRs will go down the `compile-check` (assemble-only)
path and may still skip the full Gradle `build` (where RAT/license checks
typically run), so this likely doesn’t actually prevent RAT surprises. Consider
removing those negated patterns (or adding a dedicated docs/RAT path) so
markdown changes run the intended checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
