diqiu50 commented on code in PR #10789:
URL: https://github.com/apache/gravitino/pull/10789#discussion_r3114809019
##########
trino-connector/integration-test/build.gradle.kts:
##########
@@ -41,13 +41,19 @@ dependencies {
testImplementation(libs.bundles.jetty)
testImplementation(libs.bundles.log4j)
testImplementation(libs.commons.cli)
- testImplementation(libs.hadoop2.common) {
+ testImplementation(libs.hadoop3.common) {
exclude("*")
}
- testImplementation(libs.hadoop2.hdfs)
- testImplementation(libs.hadoop2.mapreduce.client.core) {
+ testImplementation(libs.hadoop3.hdfs)
+ testImplementation(libs.hadoop3.hdfs.client)
+ testImplementation(libs.hadoop3.mapreduce.client.core) {
exclude("*")
}
+ // Hadoop 3.x runtime requirements (stripped by exclude("*") above)
+ testImplementation(libs.hadoop3.shaded.guava)
+ testImplementation(libs.hadoop3.shaded.protobuf)
+ testImplementation("org.apache.commons:commons-configuration2:2.8.0")
Review Comment:
We should not use the version directly here
##########
flink-connector/flink/build.gradle.kts:
##########
@@ -141,9 +141,15 @@ dependencies {
exclude("javax.servlet", "servlet-api")
exclude("org.mortbay.jetty")
}
- testImplementation(libs.hadoop2.mapreduce.client.core) {
+ testImplementation(libs.hadoop3.hdfs.client)
+ testImplementation(libs.hadoop3.mapreduce.client.core) {
exclude("*")
}
+ // Hadoop 3.x runtime requirements (stripped by exclude("*") above)
+ testImplementation(libs.hadoop3.shaded.guava)
+ testImplementation(libs.hadoop3.shaded.protobuf)
+ testImplementation("org.apache.commons:commons-configuration2:2.8.0")
+ testImplementation(libs.re2j)
Review Comment:
Same problem.
I found you add more dependency for using haddoop3, Is it correct?
##########
trino-connector/integration-test/build.gradle.kts:
##########
@@ -41,13 +41,19 @@ dependencies {
testImplementation(libs.bundles.jetty)
testImplementation(libs.bundles.log4j)
testImplementation(libs.commons.cli)
- testImplementation(libs.hadoop2.common) {
+ testImplementation(libs.hadoop3.common) {
exclude("*")
Review Comment:
I think the trino integration should not depend on hadoop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
