gauravrudragit opened a new pull request, #10813:
URL: https://github.com/apache/gravitino/pull/10813
### What changes were proposed in this pull request?
Previously, `LOG.info("Metalake dropped: {}")` was always executed after
the `dropMetalake` call regardless of whether the drop actually succeeded. This
PR restructures the conditional block so that the success log is only emitted
when `dropped == true`, and the warning log is emitted in the `else` branch
when `dropped == false`.
### Why are the changes needed?
The original code logged a success message ("Metalake dropped") even when
`metalakeDispatcher.dropMetalake()` returned `false`, which is misleading and
makes it harder to diagnose issues where a metalake silently fails to drop.
### Does this PR introduce _any_ user-facing change?
No. This is a server-side logging fix only.
### How was this patch tested?
Existing unit and integration tests for `MetalakeOperations` cover the drop
path. No new behavior was introduced, so no new tests were added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
