jerryshao commented on code in PR #10670:
URL: https://github.com/apache/gravitino/pull/10670#discussion_r3098440839


##########
clients/client-python/gravitino/client/generic_fileset.py:
##########
@@ -72,3 +82,17 @@ def support_credentials(self) -> SupportsCredentials:
 
     def get_credentials(self) -> List[Credential]:
         return self._object_credential_operations.get_credentials()
+

Review Comment:
   Do you need to implement this method here and below for all the metadata 
objects?
   
   ```
       def supports_tags(self) -> SupportsTags:
           return self
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to