Abyss-lord commented on PR #10760: URL: https://github.com/apache/gravitino/pull/10760#issuecomment-4264653694
> Hi @Abyss-lord, I noticed that your PR #10670 already covers the `SupportsTags` implementation for `GenericFileset`, which overlaps with this PR. I respect your work on this and don't want to create duplicate efforts. > > That said, I noticed that this PR currently has more comprehensive tests for the fileset tag operations. I'd like to propose two options for how we can collaborate: > > **Option A**: I close this PR and contribute my test cases to your PR #10670. We can coordinate on how to integrate them — for example, I can submit a PR to your fork's branch, or share the test code directly for you to cherry-pick. > > **Option B**: As @jerryshao suggested finishing the functionality one by one, we could split the scope — your PR focuses on Column, Schema, Table, Model, and Catalog tag support, while this PR handles the Fileset part. I'm happy to collaborate on either PR, and you're also welcome to push changes here if that works better. > > Of course, if you have other ideas I'm open to them as well. Looking forward to your thoughts! Thanks for the proposal. My preference is to first merge PR #10670. @sunyuhan1998 Once that is in, you can rebase your branch on the latest main, and add tests. We can also discuss splitting `Role` and `Tag` into separate PRs afterward to avoid further conflicts.I'm happy to work together with everyone on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
