jerryshao commented on code in PR #10724:
URL: https://github.com/apache/gravitino/pull/10724#discussion_r3079421008


##########
design-docs/gravitino-logical-view-management.md:
##########
@@ -0,0 +1,1051 @@
+# Design of Logical View Management in Gravitino
+
+## Background
+
+In modern data lakehouse architectures, views serve as a fundamental 
abstraction for data access, security enforcement, and query simplification. 
Organizations leverage multiple query engines (Trino, Spark, Hive) to access 
the same underlying data, but view management across these heterogeneous 
systems presents significant challenges:
+
+- **Portability Gap**: A view created in Trino cannot be read by Spark, and 
vice versa, due to differences in SQL dialects and metadata storage formats.
+- **Fragmented Governance**: Views are scattered across different metastores 
(HMS, Iceberg REST Catalog, engine-specific stores), making unified access 
control and auditing difficult.
+- **Inconsistent Security**: Each engine implements its own security model 
(definer/invoker), leading to inconsistent access control behavior across the 
data platform.
+
+Apache Gravitino, as a unified metadata management system, is well-positioned 
to address these challenges by providing centralized view management with 
multi-engine compatibility.
+
+---
+
+## Goals
+
+1. **Multi-Engine Compatibility**: Views managed by Gravitino are visible and 
manageable across engines. Multi-dialect SQL representation storage enables 
cross-engine view sharing.
+
+2. **Unified View Management**: Provide standard CRUD operations for views:
+   - Create view
+   - Get/List views
+   - Alter view (update SQL, add representations, modify properties)
+   - Drop view
+
+3. **Capability-Driven Storage Strategy**: Automatically select the optimal 
storage strategy based on each catalog's capabilities — no user-facing storage 
mode configuration needed. Gravitino transparently handles delegation, 
extension, and full management per catalog type.
+
+4. **Access Control Integration**: Integrate with Gravitino's existing access 
control framework to provide metadata-level privileges (CREATE_VIEW, 
SELECT_VIEW, DROP_VIEW). Data-level access control remains the responsibility 
of the underlying compute engines.
+
+5. **Audit Support**: View operations should be auditable with complete audit 
information.
+
+6. **Event System Integration**: View operations should emit events for users 
to hook into.
+
+---
+
+## Non-Goals
+
+1. **Materialized Views**: This design focuses on logical views only. 
Materialized views with physical storage are out of scope. IRC-based 
materialized views are a planned follow-on that builds on the logical view 
infrastructure established here; they represent a meaningful product 
differentiator that no other open metadata catalog currently offers.
+
+2. **Temporary Views**: Session-scoped temporary views are managed by engines 
themselves and don't require persistent management.
+
+3. **SQL Transpilation**: Gravitino will not automatically convert SQL between 
dialects. Users are responsible for providing correct SQL representations for 
each target dialect.
+
+4. **Query Execution**: Gravitino manages view metadata only. Actual query 
execution is handled by the compute engines.
+
+---
+
+## Proposal
+
+### Namespace
+
+Views are registered under a specified schema in relational catalogs, 
following the three-level namespace hierarchy:
+
+```
+metalake
+  └── catalog (relational)
+        └── schema
+              └── view
+```
+
+This is consistent with Gravitino's existing namespace design for tables and 
functions. **Views and tables share the same namespace within a schema** — a 
view and a table cannot have the same name under the same schema. This follows 
the standard behavior of most relational databases (MySQL, PostgreSQL, Hive, 
etc.).
+
+---
+
+### View Metadata Model
+
+#### Core View Structure
+
+```
+View
+├── name: string                          # View name (unique within schema, 
shared namespace with tables)
+├── comment: string                       # Optional description
+├── columns: array<ViewColumn>            # View schema definition
+│   └── ViewColumn
+│       ├── name: string
+│       ├── type: DataType
+│       └── comment: string (optional)
+├── representations: array<Representation>    # Multi-dialect view definitions 
(one per dialect)
+│   └── Representation
+│       ├── type: string                      # Representation type, currently 
only "sql"
+│       └── SQLRepresentation (type="sql")
+│           ├── dialect: string               # e.g., "trino", "spark", "hive" 
(unique within a view)
+│           ├── sql: string                   # The view definition SQL
+│           ├── defaultCatalog: string        # Default catalog for 
unqualified refs
+│           └── defaultSchema: string         # Default schema for unqualified 
refs
+├── securityConfig: SecurityConfig
+│   └── securityMode: enum                # DEFINER | INVOKER
+├── properties: map<string, string>       # Extensible key-value properties
+└── auditInfo: AuditInfo                  # Creation/modification timestamps 
and users
+```
+
+**Field Details:**
+
+- **columns**: The view's output schema definition. Required.
+  - Typically provided by the engine connector, not by users directly — when a 
user executes `CREATE VIEW AS SELECT ...`, the engine infers the output schema 
and passes it to Gravitino.
+  - Gravitino does not parse SQL or validate column-SQL consistency. 
Mismatches surface at query time in the engine.
+  - Not auto-updated when underlying table schemas change — users must 
explicitly alter the view.
+
+- **representations**: The multi-dialect definitions of a view. At least one 
required; each dialect unique per view.
+  - Designed for extensibility via a `type` field. Currently only `type="sql"` 
(`SQLRepresentation`) is defined.
+  - Future versions may introduce other representation types (e.g., 
dataframe-based definitions) without breaking the existing model.
+
+- **dialect**: A free-form string identifying the SQL dialect (e.g., 
`"trino"`, `"spark"`, `"hive"`, `"flink"`).
+  - Not a fixed enum — new dialects can be added without API changes.
+  - Gravitino provides a set of standard dialect constants (e.g., 
`Dialects.TRINO`, `Dialects.SPARK`) for engine connectors to use, reducing the 
risk of typos while preserving extensibility.
+  - Engine connectors use this value to locate the appropriate representation 
when loading a view.
+
+- **defaultCatalog / defaultSchema**: The catalog and schema context in which 
the SQL was authored. Optional, per-representation.
+  - Used by engines to resolve unqualified table references (e.g., `FROM 
orders` → `FROM defaultCatalog.defaultSchema.orders`).
+  - View SQL may contain cross-catalog references (e.g., 
`catalog_a.schema.table JOIN catalog_b.schema.table`). The SQL is stored as-is; 
neither Gravitino, the IRC, nor the HMS validates, rewrites, or transforms view 
SQL at any point. The compute engine is responsible for resolving and executing 
cross-catalog queries at runtime.
+
+- **securityConfig**: Declares the security execution model of the view. This 
is a metadata property stored by Gravitino and **passed through to the compute 
engine** — Gravitino does not enforce it. Whether it takes effect depends on 
the engine's capability (e.g., MySQL natively supports DEFINER/INVOKER; Iceberg 
and Hive do not).
+  - `DEFINER`: the engine should execute the view query with the view owner's 
privileges.
+  - `INVOKER`: the engine should execute the view query with the querying 
user's privileges.
+
+### Capability-Driven Storage Strategy
+
+The storage strategy is driven by what users actually care about, rather than 
exposing implementation details:
+
+1. **Usability** — Can I create and manage views through Gravitino, regardless 
of the underlying catalog?
+2. **Multi-engine** — Can my views be used by Spark, Trino, and Flink 
simultaneously?
+3. **Interoperability** — Can I see pre-existing views in the underlying 
catalog? Can views created via Gravitino be seen by other tools that access the 
underlying catalog directly?
+
+Rather than exposing catalog differences to users via a storage mode 
configuration, Gravitino automatically selects the optimal strategy based on 
each catalog's native view capability. Catalogs fall into three tiers:
+
+- **Full view support** (Iceberg, Paimon) — Natively support multi-dialect 
view storage and CRUD operations.
+- **Single-dialect view support** (HMS) — Can store views, but each engine 
uses its own private format. Gravitino provides format-aware delegation to 
normalize these differences.
+- **Read-only view support** (JDBC catalogs) — Can store views, but engine 
dialect mismatch makes write operations impractical. Gravitino provides 
read-only discovery in v1.
+- **No view support** (Hudi, Generic/Delta/Lance, etc.) — Do not support view 
operations at all.
+
+The table below maps each tier to the corresponding storage strategy:
+
+| Catalog Type | Strategy | Description |
+|-------------|----------|-------------|
+| **Iceberg** | Complete delegation | All CRUD delegated to Iceberg catalog 
(native multi-dialect support) |
+| **Paimon** | Complete delegation | All CRUD delegated to Paimon catalog 
(native multi-dialect support, Hive/REST backends) |
+| **HMS** | Format-aware delegation | Gravitino detects engine-specific 
formats, normalizes view definitions, and writes new views in Gravitino 
standard format (see [HMS View Behavior](#hms-view-behavior) for details) |
+| **JDBC** (MySQL, PostgreSQL, Doris, StarRocks, etc.) | Read-only discovery 
(v1) | Pre-existing database views are auto-discovered and exposed through 
Gravitino; CREATE VIEW not supported in v1 (future enhancement) |
+| **Catalogs without native view support** (Hudi, Generic/Delta/Lance, etc.) | 
Fully Gravitino-managed | All view metadata stored in Gravitino DB |
+
+#### Per-Catalog CRUD Behavior
+
+For **complete delegation** catalogs (Iceberg, Paimon), all operations are 
delegated to the underlying catalog. Gravitino's role: pure proxy + privilege 
control + event audit, consistent with Table architecture.
+
+For **fully Gravitino-managed** catalogs (Hudi, Generic/Delta/Lance, etc.), 
all operations are handled by Gravitino DB.
+
+For **format-aware delegation** catalogs (HMS), behavior is described in 
detail in the [HMS View Behavior](#hms-view-behavior) section below.
+
+For **read-only discovery** catalogs (JDBC), behavior is as follows:
+
+| Operation | Behavior |
+|-----------|----------|
+| Load | Read view metadata from underlying database via JDBC; return SQL text 
+ schema |
+| List | List all views in the underlying database |
+| Create / Alter / Drop | Not supported in v1; return clear error directing 
users to IRC-backed catalogs |
+
+> **JDBC View Column Discovery:** For JDBC catalogs, view column information 
is discovered via query-based introspection (`SELECT * FROM <view> WHERE 1=0`) 
using `ResultSetMetaData`, rather than `DatabaseMetaData.getColumns()`. This 
ensures computed and expression columns are correctly captured in the view 
schema.
+
+#### Sequence Diagrams
+
+The following diagrams illustrate how each strategy works in practice, 
highlighting the key benefits: existing views remain visible, and the existing 
ecosystem continues to work without disruption. In addition to engine 
connectors, data platforms can also create and manage views with any dialect 
directly through Gravitino's REST API, without depending on a specific query 
engine.
+
+**1. Complete Delegation (Iceberg)**
+
+Gravitino acts as a pure proxy. All operations delegated to the Iceberg 
catalog, which natively supports multi-dialect view storage.
+
+```mermaid
+sequenceDiagram
+    participant Engine as Trino / Spark
+    participant GC as Gravitino Connector
+    participant G as Gravitino Server
+    participant IC as Iceberg Catalog
+
+    Note over Engine,IC: CreateView — pure delegation, zero overhead
+    Engine->>GC: CREATE VIEW v1 AS SELECT ...
+    GC->>G: createView(v1, sql, dialect="trino")
+    G->>IC: createView(v1, representations=[{trino, sql}])
+    IC-->>G: OK (view stored with multi-dialect support)
+    G-->>GC: OK
+    GC-->>Engine: View created
+
+    Note over Engine,IC: Another engine can add its own dialect
+    Engine->>GC: ALTER VIEW v1 ADD REPRESENTATION (spark, sql2)
+    GC->>G: alterView(v1, addRepresentation={spark, sql2})
+    G->>IC: replaceView(v1, representations=[{trino, sql}, {spark, sql2}])
+    IC-->>G: OK
+    G-->>GC: OK
+    GC-->>Engine: Representation added
+```
+
+**2. Format-Aware Delegation (HMS)**
+
+See the [HMS View Behavior](#hms-view-behavior) section below for detailed 
sequence diagrams and behavior specification.
+
+**3. Read-Only Discovery (JDBC — e.g., MySQL) [v1]**
+
+Engines cannot natively issue view DDL against JDBC data sources. In v1, 
Gravitino provides read-only discovery of pre-existing database views. CREATE 
VIEW against JDBC catalogs is not supported; users needing managed views should 
use IRC-backed catalogs.
+
+```mermaid
+sequenceDiagram
+    participant MC as MySQL Client
+    participant Engine as Trino / Spark
+    participant GC as Gravitino Connector
+    participant G as Gravitino Server
+    participant DB as MySQL Database
+
+    Note over MC,DB: Pre-existing view created outside Gravitino
+    MC->>DB: CREATE VIEW v_report AS SELECT ...
+    DB-->>MC: View created
+
+    Note over Engine,DB: LoadView — Gravitino discovers the DB view
+    Engine->>GC: SELECT * FROM v_report
+    GC->>G: loadView(v_report)
+    G->>DB: query metadata (v_report)
+    DB-->>G: view SQL + schema (MySQL dialect)
+    G-->>GC: View(v_report, sql, dialect="mysql", columns)
+    GC-->>Engine: View metadata
+    Note over Engine: ⚠️ Engine parses SQL with its own 
parser.<br/>ANSI-compatible SQL works.<br/>MySQL-specific syntax may fail.
+
+    Note over Engine,DB: CreateView — not supported in v1
+    Engine->>GC: CREATE VIEW v_analytics AS SELECT ...
+    GC->>G: createView(v_analytics, ...)
+    G-->>GC: ❌ Error: CREATE VIEW not supported for JDBC catalogs.<br/>Use an 
IRC-backed catalog for managed views.
+    GC-->>Engine: Error
+
+    Note over DB: ✅ Existing views visible through Gravitino<br/>without any 
migration
+```
+
+**4. Fully Gravitino-Managed (Hudi, Delta, etc.)**
+
+For catalogs without any native view support, Gravitino provides full view 
capability — a feature that didn't exist before.
+
+```mermaid
+sequenceDiagram
+    participant Engine as Trino / Spark
+    participant GC as Gravitino Connector
+    participant G as Gravitino Server
+    participant GDB as Gravitino DB
+
+    Note over Engine,GDB: CreateView — Gravitino provides view capability
+    Engine->>GC: CREATE VIEW v1 AS SELECT ...
+    GC->>G: createView(v1, sql, dialect="trino")
+    G->>GDB: store(v1, representations=[{trino, sql}], version=1)
+    GDB-->>G: OK
+    G-->>GC: OK
+    GC-->>Engine: View created
+
+    Note over Engine,GDB: LoadView from another engine
+    Engine->>GC: SELECT * FROM v1
+    GC->>G: loadView(v1)
+    G->>GDB: load(v1)
+    GDB-->>G: View(v1, representations=[{trino, sql}])
+    G-->>GC: View(v1, representations=[{trino, sql}])
+    GC-->>Engine: Attempt execution with available SQL
+
+    Note over GDB: ✅ View capability added to catalogs that lacked it
+```
+
+---
+
+### View Metadata Storage
+
+View metadata is stored in Gravitino's relational database. Depending on the 
catalog type, the DB may store full view metadata (catalogs without native view 
support). For complete delegation catalogs (Iceberg, Paimon), Gravitino DB is 
not used. For HMS catalogs (format-aware delegation), views are stored in HMS 
only — Gravitino DB is not used in v1. For JDBC catalogs (read-only discovery 
in v1), Gravitino DB is not used.
+
+#### view_meta table
+
+The main table stores view-level metadata that is version-independent.
+
+```sql
+CREATE TABLE IF NOT EXISTS `view_meta` (
+    `view_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'view id',
+    `view_name` VARCHAR(128) NOT NULL COMMENT 'view name',
+    `metalake_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'metalake id',
+    `catalog_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'catalog id',
+    `schema_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'schema id',
+    `audit_info` MEDIUMTEXT NOT NULL COMMENT 'view audit info (JSON)',
+    `current_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'current version 
pointer',
+    `latest_version` INT UNSIGNED NOT NULL DEFAULT 1 COMMENT 'latest version 
number',
+    `deleted_at` BIGINT(20) UNSIGNED NOT NULL DEFAULT 0 COMMENT 'soft delete 
timestamp',
+    PRIMARY KEY (`view_id`),
+    UNIQUE KEY `uk_sid_vn_del` (`schema_id`, `view_name`, `deleted_at`),
+    KEY `idx_mid` (`metalake_id`),
+    KEY `idx_cid` (`catalog_id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin COMMENT 'view 
metadata';
+```
+
+#### view_version_info table
+
+Each alter operation creates a new version. The version table stores 
version-specific metadata including comment, columns snapshot, properties, 
representations, and audit info. Representations are stored as a JSON array.
+
+```sql
+CREATE TABLE IF NOT EXISTS `view_version_info` (
+    `id` BIGINT(20) UNSIGNED NOT NULL AUTO_INCREMENT COMMENT 'auto increment 
id',
+    `metalake_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'metalake id',
+    `catalog_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'catalog id',
+    `schema_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'schema id',
+    `view_id` BIGINT(20) UNSIGNED NOT NULL COMMENT 'view id',
+    `version` INT UNSIGNED NOT NULL COMMENT 'view version',
+    `view_comment` TEXT DEFAULT NULL COMMENT 'version-specific comment',
+    `columns` MEDIUMTEXT NOT NULL COMMENT 'view columns definition snapshot 
(JSON)',
+    `properties` MEDIUMTEXT DEFAULT NULL COMMENT 'view properties (JSON)',
+    `security_mode` VARCHAR(32) NOT NULL DEFAULT 'DEFINER' COMMENT 'DEFINER or 
INVOKER, immutable in V1',
+    `representations` MEDIUMTEXT NOT NULL COMMENT 'SQL representations (JSON 
array)',
+    `audit_info` MEDIUMTEXT NOT NULL COMMENT 'version audit info (JSON)',
+    `deleted_at` BIGINT(20) UNSIGNED NOT NULL DEFAULT 0 COMMENT 'soft delete 
timestamp',
+    PRIMARY KEY (`id`),
+    UNIQUE KEY `uk_vid_ver_del` (`view_id`, `version`, `deleted_at`),
+    KEY `idx_mid` (`metalake_id`),
+    KEY `idx_cid` (`catalog_id`),
+    KEY `idx_sid` (`schema_id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin COMMENT 'view 
version info';
+```
+
+---
+
+### HMS View Behavior
+
+HMS (Hive Metastore) requires special handling because different query engines 
store views in HMS using **incompatible private formats**. Unlike IRC (which 
has a standardized view API), HMS is a raw metadata store where the view format 
depends entirely on which engine created the view. Gravitino implements 
**format-aware delegation** to normalize these differences.
+
+#### Engine Detection Mechanism
+
+When reading a view from HMS (`tableType = "VIRTUAL_VIEW"`), Gravitino 
identifies the creating engine by checking HMS `Table.parameters` in the 
following priority order:
+
+| Priority | Condition | Engine | SQL Extraction | Schema Extraction |
+|----------|-----------|--------|----------------|-------------------|
+| 1 | `presto_view = "true"` AND `comment` ≈ `"Presto View"` | Trino | Decode 
Base64 JSON blob from `viewOriginalText` → `originalSql` field | From Base64 
JSON blob → `columns` field |
+| 2 | `spark.sql.create.version` exists | Spark | `viewOriginalText` (Spark 
SQL) | `sd.cols`, or `spark.sql.sources.schema` property if `sd.cols` is empty |
+| 3 | `is_generic = "true"` AND `flink.schema.0.name` exists | Flink | 
`viewOriginalText` (Flink SQL) | Deserialized from `flink.schema.N.name` / 
`flink.schema.N.data-type` properties |
+| 4 | None of the above | Hive (native) | `viewOriginalText` or 
`viewExpandedText` (HiveQL) | `sd.cols` |
+
+> **Source code references**: Detection conditions are verified against engine 
source code — Trino's `ViewReaderUtil.isTrinoView()`, Spark's 
`HiveExternalCatalog` properties, and Flink's `HiveTableUtil.isHiveTable()`.
+
+#### CRUD Behavior
+
+| Operation | Behavior |
+|-----------|----------|
+| **LoadView** | Read HMS table → detect engine via priority chain above → 
extract SQL, schema, dialect → return standardized Gravitino View definition |
+| **ListViews** | List all `VIRTUAL_VIEW` entries from HMS → classify each by 
detection chain → return with dialect info |
+| **CreateView** | Write to HMS in the creating engine's native format (see 
[CreateView Format](#createview-format) below) |
+| **AlterView** | Update the HMS table entry; maintain the original engine 
format. v1 supports alter only for Gravitino-created views. |
+| **DropView** | Delegate to HMS — drop the HMS table entry |
+
+#### CreateView Format
+
+When a view is created through Gravitino (e.g., Trino user runs `CREATE VIEW` 
via Gravitino connector), it is written to HMS **in the creating engine's 
native format**, ensuring that engines connecting directly to HMS can also 
recognize and execute the view.
+
+| Dialect | HMS Format | Key Properties | viewOriginalText |
+|---------|-----------|---------------|-----------------|
+| `trino` | Trino native | `presto_view=true`, `comment=Presto View`, 
`trino_created_by`, `trino_version` | `/* Presto View: <Base64(JSON)> */` |
+| `spark` | Spark native | `spark.sql.create.version`, 
`view.query.out.numCols`, `view.query.out.col.N` | Plain Spark SQL text |
+| `hive` | Hive native | No special properties | Plain HiveQL text |
+| `flink` | Flink native (v1.1) | `is_generic=true`, `flink.schema.N.name`, 
`flink.schema.N.data-type` | Plain Flink SQL text |
+
+**Implementation note:** The Gravitino engine connector must pass sufficient 
metadata (beyond just SQL text and columns) for the HMS catalog provider to 
reconstruct the engine-native format. For example, the Trino connector needs to 
pass the `ConnectorViewDefinition` fields (`catalog`, `schema`, `owner`, 
`runAsInvoker`) as view properties, which the HMS provider uses to build the 
Base64 JSON blob.
+
+**v1 limitation:** Each HMS view stores exactly one dialect — the dialect of 
the creating engine. Multi-dialect views in HMS are not supported in v1. For 
multi-dialect view support, use IRC-backed catalogs.

Review Comment:
   I think it's fine as a limitation. We don't need to make things complicated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to