yuqi1129 commented on PR #10774:
URL: https://github.com/apache/gravitino/pull/10774#issuecomment-4242363354
Addressed Copilot comments in commit cda51c790.
Fixed items:
1) Default value mismatch + integer overflow risk for auth version columns
- Changed `role_grants_version` / `securable_objects_version` to
BIGINT/BIGINT UNSIGNED
- Unified initial default to `0` in all 1.3.0 schema + upgrade scripts
(PostgreSQL/MySQL/H2)
2) Empty `IN ()` risk in batch role-version query
- Updated `RoleMetaBaseSQLProvider#batchGetSecurableObjectsVersions` to use
`<choose>`:
- non-empty input => normal `IN (...)`
- empty/null input => `1 = 0`
3) Owner mapper single-row risk on non-unique predicate
- Changed owner lookup API to return list:
- `selectOwnerByMetadataObjectId` -> `selectOwnersByMetadataObjectId`
- return type: `List<OwnerRelInfoPO>`
- updated mapper/provider factory/base provider method names accordingly
Validation:
- `./gradlew --no-daemon :core:spotlessApply`
- `./gradlew --no-daemon :core:compileJava`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
