yuqi1129 commented on code in PR #10726:
URL: https://github.com/apache/gravitino/pull/10726#discussion_r3064519675
##########
catalogs/catalog-glue/src/main/java/org/apache/gravitino/catalog/glue/GlueTablePropertiesMetadata.java:
##########
@@ -26,12 +30,36 @@
/**
* Properties metadata for Glue tables.
*
- * <p>TODO PR-02: support passthrough of Glue Table.parameters() keys such as
{@code table_type} and
- * {@code metadata_location} for Iceberg, Delta, and other formats.
+ * <p>Defines well-known Glue {@code Table.parameters()} keys that Gravitino
exposes. All entries
+ * are optional and mutable, reflecting that Glue stores them as free-form
key-value pairs. Unknown
+ * parameters from {@code Table.parameters()} are passed through transparently
by the catalog
+ * operations layer and are not validated here.
+ *
+ * <p>Note: storage location ({@code StorageDescriptor.location}) varies by
table format and is
+ * handled per-format in the Table CRUD layer, not declared here.
*/
public class GlueTablePropertiesMetadata extends BasePropertiesMetadata {
- private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA =
ImmutableMap.of();
+ private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA =
+ ImmutableMap.<String, PropertyEntry<?>>builder()
+ .put(
+ TABLE_FORMAT_TYPE,
+ stringOptionalPropertyEntry(
+ TABLE_FORMAT_TYPE,
+ "Glue table format type stored in Table.parameters(). Common
values:"
+ + " ICEBERG, HIVE, DELTA, PARQUET.",
Review Comment:
Do we only support those four types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
