Copilot commented on code in PR #10744:
URL: https://github.com/apache/gravitino/pull/10744#discussion_r3064421494
##########
mcp-server/pyproject.toml:
##########
@@ -28,6 +28,10 @@ dependencies = [
"parameterized>=0.9.0",
"pytest>=8.4.1",
"pylint>=2.20.0",
+ # pydocket (a transitive dep of fastmcp>=2.14.0) requires
fakeredis>=2.32.1, but fakeredis
+ # 2.35.0 removed FakeConnection from fakeredis.aioredis which pydocket
still uses. Pin to
+ # <2.35.0 until pydocket is updated.
+ "fakeredis<2.35.0",
Review Comment:
The pin is only an upper bound ("fakeredis<2.35.0"). Since the rationale
depends on pydocket requiring fakeredis>=2.32.1, consider encoding the full
intended range (e.g., adding the lower bound) to prevent the solver from
selecting an unexpectedly old fakeredis version if transitive constraints
change later.
```suggestion
# >=2.32.1,<2.35.0 until pydocket is updated.
"fakeredis>=2.32.1,<2.35.0",
```
##########
mcp-server/pyproject.toml:
##########
@@ -28,6 +28,10 @@ dependencies = [
"parameterized>=0.9.0",
"pytest>=8.4.1",
"pylint>=2.20.0",
+ # pydocket (a transitive dep of fastmcp>=2.14.0) requires
fakeredis>=2.32.1, but fakeredis
+ # 2.35.0 removed FakeConnection from fakeredis.aioredis which pydocket
still uses. Pin to
+ # <2.35.0 until pydocket is updated.
Review Comment:
This adds a temporary version pin, but the comment doesn’t reference a
tracking issue/PR. Please include the relevant issue number (e.g., #10743)
and/or an upstream pydocket issue so it’s clear when/why this pin can be
removed.
```suggestion
# TODO(#REPLACE_WITH_TRACKING_ISSUE): pydocket (a transitive dep of
fastmcp>=2.14.0)
# requires fakeredis>=2.32.1, but fakeredis 2.35.0 removed
FakeConnection from
# fakeredis.aioredis, which pydocket still uses. Pin fakeredis to
<2.35.0 until the
# tracked pydocket/fakeredis compatibility issue is resolved.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
