roryqi commented on code in PR #10652:
URL: https://github.com/apache/gravitino/pull/10652#discussion_r3029305639
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/rest/IcebergConfigOperations.java:
##########
@@ -98,13 +99,19 @@ public IcebergConfigOperations(IcebergCatalogWrapperManager
catalogWrapperManage
@Produces(MediaType.APPLICATION_JSON)
@Timed(name = "config." + MetricNames.HTTP_PROCESS_DURATION, absolute = true)
@ResponseMetered(name = "config", absolute = true)
- public Response getConfig(@DefaultValue("") @QueryParam("warehouse") String
warehouse) {
- String catalogName = getCatalogName(warehouse);
+ public Response getConfig(
+ @PathParam("prefix") String prefix,
+ @DefaultValue("") @QueryParam("warehouse") String warehouse) {
+ String prefixCatalogName = IcebergRESTUtils.getCatalogName(prefix);
+ String catalogName =
+ StringUtils.isNotBlank(prefix) ? prefixCatalogName :
getCatalogName(warehouse);
Review Comment:
Iceberg creator said that `A prefix is not allowed for the config endpoint,
so I don't think you would have this problem.`
So we should remove `prefix` in the url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
