yuqi1129 commented on code in PR #10480:
URL: https://github.com/apache/gravitino/pull/10480#discussion_r3026383948
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -190,6 +190,31 @@ private Configs() {}
.booleanConf()
.createWithDefault(true);
+ public static final ConfigEntry<Boolean> CATALOG_CLASSLOADER_SHARING_ENABLED
=
+ new ConfigBuilder("gravitino.catalog.classloader.sharing.enabled")
+ .doc(
+ "Whether to share ClassLoaders across catalogs with identical
isolation-relevant "
+ + "properties. When true (default), catalogs with the same
isolation key reuse "
+ + "a single ClassLoader, significantly reducing Metaspace
memory usage. When "
+ + "false, each catalog gets its own dedicated ClassLoader as
in previous "
+ + "releases.")
+ .version(ConfigConstants.VERSION_1_2_0)
+ .booleanConf()
+ .createWithDefault(true);
+
+ public static final ConfigEntry<List<String>>
CATALOG_CLASSLOADER_ISOLATION_EXTRA_PROPERTIES =
+ new
ConfigBuilder("gravitino.catalog.classloader.isolation.extra-properties")
+ .doc(
+ "Additional catalog property keys used to determine ClassLoader
isolation. "
+ + "Catalogs that differ in any of these properties will use
separate "
+ + "ClassLoaders. This supplements the built-in default
isolation properties "
+ + "(package, authorization-provider, Kerberos identity,
metastore.uris, "
+ + "jdbc-url, fs.defaultFS) and cannot be used to remove
them.")
+ .version(ConfigConstants.VERSION_1_2_0)
Review Comment:
This configuration item is too complex for users to use. I would suggest you
remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
