(gravitino) branch main updated: [#10621] fix(core): use metadata object name for metalake identifier resolution (#10638)

[jmclean]

This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 2a541d9cc0 [#10621] fix(core): use metadata object name for metalake 
identifier resolution (#10638)
2a541d9cc0 is described below

commit 2a541d9cc0c7a43838aed5d14cc129b921485884
Author: Tanner Smith <griffonb...@proton.me>
AuthorDate: Wed Apr 1 20:57:39 2026 -0400

    [#10621] fix(core): use metadata object name for metalake identifier 
resolution (#10638)
    
    ### What changes were proposed in this pull request?
    
    Updated the METALAKE branch in `MetadataObjectUtil.toEntityIdent` to
    build the identifier from `metadataObject.name()` instead of the
    `metalakeName` context parameter.
    
    ### Why are the changes needed?
    
    When a request carried a METALAKE metadata object whose name differed
    from the surrounding `metalakeName` context, `toEntityIdent` resolved
    against the context metalake rather than the target object. This meant
    validation in `checkMetadataObject` could pass against the wrong
    metalake for generic REST flows like owner operations.
    
    ### Does this PR introduce any user-facing change?
    
    No. This is an internal correctness fix. The existing validation in
    `checkMetadataObject` already rejects cases where
    `metalake.equals(object.name())` is false, so mismatched requests were
    caught there. This change makes `toEntityIdent` itself consistent with
    that expectation.
    
    ### How was this patch tested?
    
    Added a test case to `TestMetadataObjectUtil` that verifies the metadata
    object's own name is used for the identifier rather than the surrounding
    context metalake name.
    
    Fixes #10621
    
    Signed-off-by: Tanner Smith <griffonb...@proton.me>
---
 .../main/java/org/apache/gravitino/utils/MetadataObjectUtil.java   | 2 +-
 .../java/org/apache/gravitino/utils/TestMetadataObjectUtil.java    | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git 
a/core/src/main/java/org/apache/gravitino/utils/MetadataObjectUtil.java 
b/core/src/main/java/org/apache/gravitino/utils/MetadataObjectUtil.java
index 8b075bff1f..299099b2cc 100644
--- a/core/src/main/java/org/apache/gravitino/utils/MetadataObjectUtil.java
+++ b/core/src/main/java/org/apache/gravitino/utils/MetadataObjectUtil.java
@@ -110,7 +110,7 @@ public class MetadataObjectUtil {
 
     switch (metadataObject.type()) {
       case METALAKE:
-        return NameIdentifierUtil.ofMetalake(metalakeName);
+        return NameIdentifierUtil.ofMetalake(metadataObject.name());
       case ROLE:
         return AuthorizationUtils.ofRole(metalakeName, metadataObject.name());
       case TAG:
diff --git 
a/core/src/test/java/org/apache/gravitino/utils/TestMetadataObjectUtil.java 
b/core/src/test/java/org/apache/gravitino/utils/TestMetadataObjectUtil.java
index 97c1fbf0a9..4471a1e0ec 100644
--- a/core/src/test/java/org/apache/gravitino/utils/TestMetadataObjectUtil.java
+++ b/core/src/test/java/org/apache/gravitino/utils/TestMetadataObjectUtil.java
@@ -97,6 +97,13 @@ public class TestMetadataObjectUtil {
         MetadataObjectUtil.toEntityIdent(
             "metalake", MetadataObjects.of(null, "metalake", 
MetadataObject.Type.METALAKE)));
 
+    // Verify that toEntityIdent uses the metadata object's name, not the 
context metalakeName
+    Assertions.assertEquals(
+        NameIdentifier.of("target_metalake"),
+        MetadataObjectUtil.toEntityIdent(
+            "request_metalake",
+            MetadataObjects.of(null, "target_metalake", 
MetadataObject.Type.METALAKE)));
+
     Assertions.assertEquals(
         NameIdentifier.of("metalake", "catalog"),
         MetadataObjectUtil.toEntityIdent(