jerryshao commented on code in PR #10610:
URL: https://github.com/apache/gravitino/pull/10610#discussion_r3021442577
##########
core/src/test/java/org/apache/gravitino/stats/storage/TestLancePartitionStatisticStorage.java:
##########
@@ -594,4 +594,57 @@ public void
testDropStatisticsWithQuoteInPartitionAndStatisticName() throws Exce
storage.close();
}
}
+
+ @Test
+ public void testUpdateStatisticsWithLargeTableId() throws Exception {
+ PartitionStatisticStorageFactory factory = new
LancePartitionStatisticStorageFactory();
+ String metalakeName = "metalake";
+ MetadataObject metadataObject =
+ MetadataObjects.of(
+ Lists.newArrayList("catalog", "schema", "table"),
MetadataObject.Type.TABLE);
+
+ EntityStore entityStore = mock(EntityStore.class);
+ TableEntity tableEntity = mock(TableEntity.class);
+ when(entityStore.get(any(), any(), any())).thenReturn(tableEntity);
+ when(tableEntity.id()).thenReturn(256L);
Review Comment:
Table entity ID is long, which is already 8 bytes. And the long value table
ID exists everywhere, do you need additional tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
