geyanggang commented on code in PR #10579:
URL: https://github.com/apache/gravitino/pull/10579#discussion_r3020311363
##########
catalogs/hive-metastore2-libs/build.gradle.kts:
##########
@@ -34,6 +34,7 @@ dependencies {
exclude(group = "com.google.code.findbugs")
exclude(group = "com.google.guava")
exclude(group = "log4j")
+ exclude(group = "net.java.dev.jets3t")
Review Comment:
I verified this on the main branch (before this PR) by scanning every JAR in
hive-metastore2-libs/build/libs — including hadoop-common-2.10.2.jar — for
NativeS3FileSystem and s3native classes. Zero matches. The S3N filesystem
implementation is not bundled in hadoop-common; it lives in hadoop-aws, which
is not a dependency of this module.
So jets3t is unreachable dead code here — no class in these JARs imports or
loads it. Additionally, Gravitino has no s3n:// usage anywhere in the codebase;
all S3 access uses s3a://.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
