justinmclean commented on PR #10619: URL: https://github.com/apache/gravitino/pull/10619#issuecomment-4167746662
The reason the order matters is as @pythaac described in his PR/unit test. The test uses a real RootAllocator and VarCharVector, and the reported failure is that if the cached Dataset is not explicitly closed before allocator.close(), allocator shutdown can fail with IllegalStateException: Allocator closed with outstanding buffers allocated. So this is not only about keeping a preferred order, invalidateAll() alone does not release the dataset resources, and that explicit dataset.close() before allocator.close() is required to avoid the shutdown failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
