Copilot commented on code in PR #10624:
URL: https://github.com/apache/gravitino/pull/10624#discussion_r3019615326
##########
docs/lakehouse-paimon-catalog.md:
##########
@@ -49,13 +49,6 @@ Builds with Apache Paimon `1.2`.
| `s3-secret-access-key` | The secret key of the
AWS S3.
| (none)
| required if the value of `warehouse` is a S3 path
| 0.7.0-incubating |
:::note
-<<<<<<< HEAD
-If you want to use the `oss` or `s3` warehouse, you need to place related jars
in the `catalogs/lakehouse-paimon/lib` directory, more information can be found
in the [Paimon S3](https://paimon.apache.org/docs/master/filesystems/s3/).
-:::
-
-:::note
-The hive backend does not support the kerberos authentication now.
-=======
- If you want to use the `oss` or `s3` warehouse, you need to place related
jars in the `catalogs/lakehouse-paimon/lib` directory, more information can be
found in the [Paimon
S3](https://paimon.apache.org/docs/1.2/maintenance/filesystems/#s3).
Review Comment:
The docs refer to `catalogs/lakehouse-paimon/lib`, but the
distribution/build scripts copy Paimon catalog jars into
`catalogs/lakehouse-paimon/libs` (plural). Using `lib` here will send users to
the wrong directory; please align this path with the actual packaged layout.
```suggestion
- If you want to use the `oss` or `s3` warehouse, you need to place related
jars in the `catalogs/lakehouse-paimon/libs` directory, more information can be
found in the [Paimon
S3](https://paimon.apache.org/docs/1.2/maintenance/filesystems/#s3).
```
##########
docs/lakehouse-paimon-catalog.md:
##########
@@ -75,7 +68,6 @@ The hive backend does not support the kerberos authentication
now.
```
connect to Aliyun DLF, more information can be found in the [Paimon REST
Catalog](https://paimon.apache.org/docs/master/concepts/rest/overview/).
- The hive backend does not support the kerberos authentication now.
Review Comment:
Minor wording/capitalization: "kerberos" should be capitalized as
"Kerberos", and "now" can be removed to keep the statement timeless (e.g.,
"does not currently support Kerberos authentication").
```suggestion
- The Hive backend does not support Kerberos authentication.
```
##########
docs/lakehouse-paimon-catalog.md:
##########
@@ -75,7 +68,6 @@ The hive backend does not support the kerberos authentication
now.
```
connect to Aliyun DLF, more information can be found in the [Paimon REST
Catalog](https://paimon.apache.org/docs/master/concepts/rest/overview/).
Review Comment:
This sentence is a fragment (missing a leading "To") and reads awkwardly
after the example config. Consider rephrasing to a full sentence (and, if
intended as part of the REST-backend bullet, keeping it within that list item).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
