justinmclean commented on issue #10599:
URL: https://github.com/apache/gravitino/issues/10599#issuecomment-4167243301
In this case, the operation is listing models within a namespace, not
operating on a specific model. Using NameIdentifier.of(namespace.levels())
effectively turns the namespace into a model identifier, which is misleading.
For listeners or audit consumers, this can result in incorrect assumptions
about what actually failed.
So I’d frame it less as “ListModelFailureEvent is inconsistent” and more as
“the current pattern for list-related failure events may not correctly
represent the target of the operation”.
Given that, I see two reasonable paths:
1. Short term: Fix ListModelFailureEvent to reflect the namespace
being listed, since that’s the actual subject of the operation.
2. Longer term: Review all list-related FailureEvent
implementations and define a consistent representation for “collection-level”
operations (e.g. namespace-level identifiers vs entity-level identifiers).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
