This is an automated email from the ASF dual-hosted git repository.
bharos92 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new eb51750325 [#8300] fix(cli): fix output message in
RemoveModelVersionProperty (#10551)
eb51750325 is described below
commit eb51750325a5ec76d77b5544696b750a1ad0787e
Author: Arjen Aykan Kılıç <[email protected]>
AuthorDate: Tue Mar 31 10:25:06 2026 +1000
[#8300] fix(cli): fix output message in RemoveModelVersionProperty (#10551)
### What changes were proposed in this pull request?
Fixed the output message in `RemoveModelVersionProperty.java`:
- Added a missing space before "property" in the output string for both
alias and version paths.
- Removed the redundant duplicate "property" word from the message, as
also flagged by Copilot in [PR
#9557](https://github.com/apache/gravitino/pull/9557).
Before: `model alias aliasAproperty key property removed.`
After: `model alias aliasA property key removed.`
### Why are the changes needed?
The CLI output message in `RemoveModelVersionProperty` had two issues:
1. A missing space before "property" made the output unreadable (e.g.,
`aliasAproperty`).
2. The word "property" appeared twice in the message, making it
redundant. This was also identified in the Copilot review of [PR
#9557](https://github.com/apache/gravitino/pull/9557).
Fix: #8300
### Does this PR introduce _any_ user-facing change?
Yes. The CLI output message when removing a model version property is
now correctly formatted and more concise.
### How was this patch tested?
No automated tests were added as this is a minor formatting fix. Ran
existing CLI tests to verify no regressions:
```
./gradlew :clients:cli:test --tests
"org.apache.gravitino.cli.TestModelCommands"
```
All tests related to `RemoveModelVersionProperty` pass.
Co-authored-by: Bharath Krishna <[email protected]>
---
.../apache/gravitino/cli/commands/RemoveModelVersionProperty.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveModelVersionProperty.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveModelVersionProperty.java
index 28f1187ec3..d5bb79f259 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveModelVersionProperty.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveModelVersionProperty.java
@@ -99,10 +99,9 @@ public class RemoveModelVersionProperty extends Command {
}
if (alias != null) {
- printInformation(model + " alias " + alias + "property " + property + "
property removed.");
+ printInformation(model + " alias " + alias + " property " + property + "
removed.");
} else {
- printInformation(
- model + " version " + version + "property " + property + " property
removed.");
+ printInformation(model + " version " + version + " property " + property
+ " removed.");
}
}