roryqi commented on code in PR #10052:
URL: https://github.com/apache/gravitino/pull/10052#discussion_r2994752323


##########
docs/trino-connector/authentication.md:
##########
@@ -0,0 +1,136 @@
+---
+title: "Apache Gravitino Trino connector Authentication"
+slug: /trino-connector/authentication
+keyword: gravitino connector trino authentication
+license: "This software is licensed under the Apache License version 2."
+---
+
+## Authentication
+
+The Gravitino Trino connector supports authenticating to the Gravitino server 
using the same authentication mechanisms as the Gravitino Java client: Simple, 
OAuth, and Kerberos. Authentication is configured through the Trino connector 
properties file using the `gravitino.client.*` prefix.
+
+If `gravitino.client.authType` is not set, the connector operates in 
no-authentication mode and connects to the Gravitino server without any 
credentials.
+
+### Simple Authentication
+
+Simple authentication uses a username to authenticate with the Gravitino 
server.
+
+**Configuration in `etc/catalog/gravitino.properties`:**
+
+```properties
+connector.name=gravitino
+gravitino.metalake=metalake
+gravitino.uri=http://localhost:8090
+
+# Simple authentication with username
+gravitino.client.authType=simple
+gravitino.client.simpleAuthUser=admin

Review Comment:
   Could u give a better name? It will tell user that this is a connector user 
instead of a session user.
   simple.xxxUser



##########
docs/trino-connector/authentication.md:
##########
@@ -0,0 +1,136 @@
+---
+title: "Apache Gravitino Trino connector Authentication"
+slug: /trino-connector/authentication
+keyword: gravitino connector trino authentication
+license: "This software is licensed under the Apache License version 2."
+---
+
+## Authentication
+
+The Gravitino Trino connector supports authenticating to the Gravitino server 
using the same authentication mechanisms as the Gravitino Java client: Simple, 
OAuth, and Kerberos. Authentication is configured through the Trino connector 
properties file using the `gravitino.client.*` prefix.
+
+If `gravitino.client.authType` is not set, the connector operates in 
no-authentication mode and connects to the Gravitino server without any 
credentials.
+
+### Simple Authentication
+
+Simple authentication uses a username to authenticate with the Gravitino 
server.
+
+**Configuration in `etc/catalog/gravitino.properties`:**
+
+```properties
+connector.name=gravitino
+gravitino.metalake=metalake
+gravitino.uri=http://localhost:8090
+
+# Simple authentication with username
+gravitino.client.authType=simple
+gravitino.client.simpleAuthUser=admin
+```
+
+**Configuration properties:**
+
+| Property                          | Description                              
                            | Default value    | Required                       
        | Since version |
+|-----------------------------------|----------------------------------------------------------------------|------------------|----------------------------------------|---------------|
+| `gravitino.client.authType`       | Authentication type: `simple`, `oauth`, 
or `kerberos`               | (none)           | No                             
        | 1.3.0         |

Review Comment:
   We will use `oauth2` for the client. You can refer to other clients like 
Spark and Flink.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to