diqiu50 commented on code in PR #10383:
URL: https://github.com/apache/gravitino/pull/10383#discussion_r2937989908
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -427,6 +431,19 @@ private String toPartitionExpression(Transform transform) {
return quoteIdentifier(fieldName);
}
+ private void validateNoAutoIncrementColumns(JdbcColumn[] columns) {
+ if (ArrayUtils.isEmpty(columns)) {
+ return;
+ }
+
+ for (JdbcColumn column : columns) {
+ if (column.autoIncrement()) {
+ throw new UnsupportedOperationException(
+ "ClickHouse does not support auto increment column in CREATE
TABLE");
Review Comment:
You'd better add the column name in the exception
##########
catalogs-contrib/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operations/ClickHouseTableOperations.java:
##########
@@ -768,6 +789,37 @@ protected String generateAlterTableSql(
return result;
}
+ @VisibleForTesting
Review Comment:
This annotation doesn’t have any effect, right?
##########
docs/jdbc-clickhouse-catalog.md:
##########
@@ -156,15 +156,15 @@ See [Manage Relational Metadata Using
Gravitino](./manage-relational-metadata-us
### Table capabilities
-| Area | Details
|
-|---------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| Mapping | Gravitino table maps to a ClickHouse table
|
-| Engines | Local engines: MergeTree family (`MergeTree` default,
`ReplacingMergeTree`, `SummingMergeTree`, `AggregatingMergeTree`,
`CollapsingMergeTree`, `VersionedCollapsingMergeTree`, `GraphiteMergeTree`),
Tiny/Stripe/Log, Memory, File, Null, Set, Join, View, Buffer, KeeperMap, etc.
Distributed engine supports cluster mode with remote database/table and
sharding key. |
-| Ordering/Partition | MergeTree-family requires exactly one `ORDER BY`
column; only single-column identity `PARTITION BY` is supported on MergeTree
engines. Other engines reject `ORDER BY`/`PARTITION BY`.
|
-| Indexes | Primary key; data-skipping indexes
`DATA_SKIPPING_MINMAX` and `DATA_SKIPPING_BLOOM_FILTER` (fixed granularities).
|
-| Distribution | Gravitino enforces `Distributions.NONE`; no custom
distribution strategies.
|
-| Column defaults | Supported.
|
-| Unsupported | Engine change after creation; removing table
properties; auto-increment columns.
|
+| Area | Details
|
+|---------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| Mapping | Gravitino table maps to a ClickHouse table
|
+| Engines | Local engines: MergeTree family (`MergeTree` default,
`ReplacingMergeTree`, `SummingMergeTree`, `AggregatingMergeTree`,
`CollapsingMergeTree`, `VersionedCollapsingMergeTree`, `GraphiteMergeTree`),
Distributed engine supports cluster mode with remote database/table and
sharding key. |
Review Comment:
Why do we remove these engins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
