jerryshao commented on PR #10377: URL: https://github.com/apache/gravitino/pull/10377#issuecomment-4054152617
### Code review Found 1 issue: 1. `ln -sv` without the force flag (`-f`) will crash the container on restart. The script has `set -ex` active (line 21). When the container restarts, symlinks already exist, so `ln -sv` exits with \"File exists\" (exit code 1), and `set -e` aborts the script before Gravitino starts. The fix is to use `ln -sfv` instead of `ln -sv`. https://github.com/apache/gravitino/blob/fdca1acff757dd00d29b2790f45f2c7ce8163f73/dev/docker/gravitino/start-gravitino.sh#L34-L41 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
