Copilot commented on code in PR #10382:
URL: https://github.com/apache/gravitino/pull/10382#discussion_r2918019357
##########
common/src/main/java/org/apache/gravitino/dto/requests/TableUpdateRequest.java:
##########
@@ -866,7 +866,7 @@ public DeleteTableIndexRequest() {}
*/
public DeleteTableIndexRequest(String name, Boolean ifExists) {
this.name = name;
- this.ifExists = ifExists;
+ this.ifExists = ifExists != null && ifExists;
}
Review Comment:
`DeleteTableIndexRequest(String name, Boolean ifExists)` now explicitly
treats `ifExists` as optional (`null` -> `false`). To match the codebase’s
nullability conventions (this file already uses `@Nullable` for optional
params), please annotate the `ifExists` parameter as `@Nullable` and clarify in
the JavaDoc that `null` is interpreted as `false` (or add a `boolean` overload
and deprecate the boxed form).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
