yuqi1129 commented on PR #10348: URL: https://github.com/apache/gravitino/pull/10348#issuecomment-4035843826
Follow-up on JDK scope: I agree we should avoid over-opening if not necessary. For this issue (#10350), the failure is Arrow `MemoryUtil` on JDK 21, and Arrow's current Java docs (tested on JDK 11/17/21/latest) require opening `java.base/java.nio` for memory modules. So for JDK 21/24, we definitely need that `java.nio` open. I don't see evidence from this issue that the full JDK17 list is strictly required on 21/24. If we want least-privilege behavior, we could consider: 1) keep a minimal required set (at least `java.base/java.nio`) for JDK >=17, and 2) only add extra opens when a concrete dependency/runtime path needs them. If we keep the full list for safety, please add rationale in script comments (compatibility-first tradeoff). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
