nealeu commented on PR #3122:
URL: https://github.com/apache/fory/pull/3122#issuecomment-3884954556
Ah. I think I understand.
The line before the failing assertion assumes that we will use the generated
serializer for `TimeStructRef`
```
// TimeStructRef serializer already generated, enable ref tracking
doesn't take effect.
Assert.assertNotSame(struct2.date1, struct2.date2);
```
but now, with our fixes, this line will take effect, so refs are written:
```
fory.registerSerializer(Date.class, new
TimeSerializers.DateSerializer(fory, true));
```
The test assumption is therefore now incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
