nealeu commented on code in PR #3122:
URL: https://github.com/apache/fory/pull/3122#discussion_r2683265127
##########
java/fory-core/src/main/java/org/apache/fory/Fory.java:
##########
@@ -105,6 +106,7 @@ public final class Fory implements BaseFory {
private static final boolean isLittleEndian = ByteOrder.nativeOrder() ==
ByteOrder.LITTLE_ENDIAN;
private static final byte BITMAP = isLittleEndian ? isLittleEndianFlag : 0;
private static final short MAGIC_NUMBER = 0x62D4;
+ private static final AtomicInteger runtimeHashCounter = new AtomicInteger(0);
Review Comment:
Yes. That's why we were following that pattern, but moved it to Fory to
cover it being not just the initial config.
Now the incrementAndGet in the ctor and when modifying means that e.g.
Fory#1 will get 1, and Fory#2 will get 2, but then Fory#2 gets a serializer
added so it becomes 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
