This is an automated email from the ASF dual-hosted git repository. MartijnVisser pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit 87bb3057bbe95951580d55633c4ce979b484775a Author: Martijn Visser <[email protected]> AuthorDate: Mon Oct 12 14:26:24 2026 +0100 [FLINK-40971][parquet] Run ParquetTimestampITCase for all its parameters The tests were plain @Test methods inherited from FsStreamingSinkITCaseBase, so ParameterizedTestExtension never applied and each ran once with the field defaults. Run them as @TestTemplate and give the parameter fields their own indices. Generated-by: Claude Code (Claude Opus 5.5) --- .../formats/parquet/ParquetTimestampITCase.java | 33 ++++++++++++++++++++-- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTimestampITCase.java b/flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTimestampITCase.java index a40e104d4b5..cae38a93f37 100644 --- a/flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTimestampITCase.java +++ b/flink-formats/flink-parquet/src/test/java/org/apache/flink/formats/parquet/ParquetTimestampITCase.java @@ -33,6 +33,7 @@ import org.apache.flink.types.Row; import org.apache.flink.util.CollectionUtil; import org.apache.parquet.Strings; +import org.junit.jupiter.api.TestTemplate; import org.junit.jupiter.api.extension.ExtendWith; import java.sql.Timestamp; @@ -60,11 +61,13 @@ import static org.assertj.core.api.Assertions.assertThat; /** Test int64 timestamp. */ @ExtendWith(ParameterizedTestExtension.class) public class ParquetTimestampITCase extends FsStreamingSinkITCaseBase { - @Parameter public static boolean useInt64; + @Parameter public boolean useInt64; - @Parameter public static String timeunit; + @Parameter(1) + public String timeunit; - @Parameter public static boolean timezone; + @Parameter(2) + public boolean timezone; @Parameters(name = "useInt64 = {0}, timeunit = {1}, timezone = {2}") public static Object[] parameters() { @@ -79,6 +82,30 @@ public class ParquetTimestampITCase extends FsStreamingSinkITCaseBase { }; } + @Override + @TestTemplate + public void testNonPart() { + super.testNonPart(); + } + + @Override + @TestTemplate + public void testPart() { + super.testPart(); + } + + @Override + @TestTemplate + public void testMetastorePolicy() { + super.testMetastorePolicy(); + } + + @Override + @TestTemplate + public void testPartitionWithBasicDate() { + super.testPartitionWithBasicDate(); + } + @Override public Seq<Row> getData() { return JavaScalaConversionUtil.toScala(
