delei commented on code in PR #964:
URL: https://github.com/apache/fesod/pull/964#discussion_r3645841739
##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/metadata/data/CellData.java:
##########
@@ -71,6 +76,19 @@ public class CellData<T> extends AbstractCell {
*/
private FormulaData formulaData;
+ /**
+ * Sets {@link #booleanValue} from the raw {@code <v>} text of a boolean
({@code t="b"}) xlsx cell.
+ *
+ * <p>Excel encodes boolean cells using the numeric markers {@code
0}/{@code 1}, so only the exact
+ * string {@code "1"} maps to {@code true}; any other input (including
{@code "true"}) maps to
+ * {@code false}. This mirrors Apache POI's {@code
XSSFCell.getBooleanCellValue()}.
+ *
+ * @param str the raw cell value text
+ */
+ public void setBooleanValueFromString(String str) {
Review Comment:
There is no logical issue.
FYI, I will just add a point from the design perspective. I have noticed
that the CellData class is a highly abstract entity. Is it more appropriate for
the assignment of internal attributes to be handled in the subclasses
`ReadCellData` and `WriteCellData` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
