bengbengbalabalabeng commented on issue #953:
URL: https://github.com/apache/fesod/issues/953#issuecomment-5020504712
Considering this method is only used in the `CellData#booleanValue`
assignment path and is not universal. To avoid future confusion, I suggest
marking it as `@Deprecated` and adding a **note that it should not be used
outside this specific scenario and will be deleted in the future**. The actual
logic can be moved into `CellData`:
```java
public class CellData<T> extends AbstractCell {
// ......
private static final String TRUE_NUMBER = "1";
// ......
public void setBooleanValueFromString(String str) {
this.booleanValue = TRUE_NUMBER.equals(str);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
