bengbengbalabalabeng commented on code in PR #942:
URL: https://github.com/apache/fesod/pull/942#discussion_r3610307723
##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/analysis/v07/handlers/CellTagHandler.java:
##########
@@ -130,10 +149,8 @@ public void endElement(XlsxReadContext xlsxReadContext,
String name) {
tempCellData.setStringValue(tempCellData.getStringValue().trim());
}
}
-
tempCellData.checkEmpty();
tempCellData.setRowIndex(xlsxReadSheetHolder.getRowIndex());
- tempCellData.setColumnIndex(xlsxReadSheetHolder.getColumnIndex());
Review Comment:
In the previous version, when `includeColumnIndexes != null`, the assignment
of `tempCellData.setColumnIndex()` was the overridden `targetColumnIndex`. Now,
however, `tempCellData.setColumnIndex()` always uses the original
`xlsxReadSheetHolder.getColumnIndex()` instead.
I want to confirm whether this change is intentional. Would you mind
clarifying the expected behavior here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
