alaahong opened a new pull request, #954: URL: https://github.com/apache/fesod/pull/954
<!-- Thanks very much for contributing to Apache Fesod (Incubating)! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: Closed: #ISSUE Related: #ISSUE --> ## Purpose of the pull request The SQL date type fix in #912 was only applied to WriteCellData, not to CsvCell.setCellValueImpl(Date). The old code calls value.toInstant() unconditionally, which throws UnsupportedOperationException for java.sql.Date and java.sql.Time on Java 9+ (these types override toInstant() to throw because they represent date-only/time-only values). Fix: Add the same instanceof checks as WriteCellData - use toLocalDate() .atStartOfDay() for java.sql.Date and toLocalTime().atDate(...) for java.sql.Time, falling back to toInstant() for regular java.util.Date. ## What's changed? CsvCell ## Checklist - [X] I have read the [Contributor Guide](https://fesod.apache.org/community/contribution/). - [X] I have written the necessary doc or comment. - [X] I have added the necessary unit tests and all cases have passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
