bengbengbalabalabeng commented on code in PR #942:
URL: https://github.com/apache/fesod/pull/942#discussion_r3586420935


##########
fesod-sheet/src/main/java/org/apache/fesod/sheet/FesodSheet.java:
##########
@@ -330,4 +331,20 @@ public static ExcelReaderSheetBuilder readSheet(Integer 
sheetNo, String sheetNam
                 .sheetNameIfNotNull(sheetName)
                 .numRowsIfNotNull(numRows);
     }
+
+    /**
+     * Build excel the 'readSheet' targeting specific column indexes.
+     *
+     * @param sheetNo       Index of sheet, 0 base.
+     * @param columnIndexes Specific columns to read (e.g., [0, 2] for Column 
A and C).
+     * @return Excel sheet reader builder.
+     */
+    public static ExcelReaderSheetBuilder readSheetWithColumns(
+            Integer sheetNo, String sheetName, Integer numRows, List<Integer> 
columnIndexes) {
+        return new ExcelReaderSheetBuilder()
+                .sheetNoIfNotNull(sheetNo)
+                .sheetNameIfNotNull(sheetName)
+                .numRowsIfNotNull(numRows)
+                .includeColumnIndexes(columnIndexes);

Review Comment:
   Is it more appropriate to replace `includeColumnIndexes` with 
`includeColumnIndexesIfNotNull`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to