psxjoy commented on PR #948: URL: https://github.com/apache/fesod/pull/948#issuecomment-4978164433
The overall optimization looks good. A few suggestions before merging: 1. Both `ThreadLocal` maps are unbounded and may keep growing on long-lived threads. 2. Building the composite string key still creates an object on every cell. Consider using nested maps or a structured key. 3. Since `Locale.setDefault(...)` changes global JVM state, related tests should use `@ResourceLock(Resources.LOCALE)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
