alaahong commented on code in PR #916: URL: https://github.com/apache/fesod/pull/916#discussion_r3260555085
########## website/i18n/zh-cn/docusaurus-plugin-content-docs/current/sheet/help/annotation.md: ########## @@ -123,3 +123,14 @@ title: '注解' | lastRowIndex | -1 | 合并区域的最后一行索引 | | firstColumnIndex | -1 | 合并区域的第一列索引 | | lastColumnIndex | -1 | 合并区域的最后一列索引 | + +### `@FreezePane` + +为 Excel 工作表定义冻结窗格。具体参数如下： + +| 名称 | 默认值 | 描述 | +|----------------|-----|------------------------------------| +| colSplit | 0 | 水平拆分位置（即需要冻结的列数） | +| rowSplit | 0 | 垂直拆分位置（即需要冻结的行数） | Review Comment: same question with English parts ########## fesod-sheet/src/test/java/org/apache/fesod/sheet/write/style/SheetFreezePaneStrategyTest.java: ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.write.style; + +import org.apache.fesod.sheet.metadata.property.SheetFreezePaneProperty; +import org.apache.fesod.sheet.write.metadata.holder.WriteSheetHolder; +import org.apache.fesod.sheet.write.metadata.holder.WriteWorkbookHolder; +import org.apache.poi.ss.usermodel.Sheet; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.Test; +import org.mockito.Mockito; + +class SheetFreezePaneStrategyTest { + + @Test + void constructor_throws_whenColSplitNegative() { + Assertions.assertThrows(IllegalArgumentException.class, () -> new SheetFreezePaneStrategy(-1, 0, 0, 0)); + } + + @Test + void constructor_throws_whenRowSplitNegative() { + Assertions.assertThrows(IllegalArgumentException.class, () -> new SheetFreezePaneStrategy(0, -1, 0, 0)); + } + + @Test + void constructor_throws_whenLeftmostColumnNegative() { + Assertions.assertThrows(IllegalArgumentException.class, () -> new SheetFreezePaneStrategy(0, 0, -1, 0)); + } + + @Test + void constructor_throws_whenTopRowNegative() { + Assertions.assertThrows(IllegalArgumentException.class, () -> new SheetFreezePaneStrategy(0, 0, 0, -1)); + } + + @Test + void constructor_acceptsAllZeros() { + Assertions.assertDoesNotThrow(() -> new SheetFreezePaneStrategy(0, 0, 0, 0)); + Assertions.assertDoesNotThrow(() -> new SheetFreezePaneStrategy(0, 0)); + } + + @Test + void constructor_acceptsPositiveValues() { + Assertions.assertDoesNotThrow(() -> new SheetFreezePaneStrategy(2, 3, 4, 5)); + } + + @Test + void constructor_fromProperty_copiesAllFields() { Review Comment: where is the copiesAllFields ? ########## website/docs/sheet/help/annotation.md: ########## @@ -146,3 +146,14 @@ Defines a one-time absolute merge region. The parameters are as follows: | lastRowIndex | -1 | The index of the last row to merge. | | firstColumnIndex | -1 | The index of the first column to merge. | | lastColumnIndex | -1 | The index of the last column to merge. | + +### `@FreezePane` + +Define a freeze pane for an Excel sheet. The parameters are as follows: + +| Name | Default Value | Description | +|----------------|---------------|--------------------------------------------------------------------------| +| colSplit | 0 | Horizontal position of split. | +| rowSplit | 0 | Vertical position of split. | Review Comment: Please correct me if misunderstanding: colSplit is vertical splitting rowSplit is the horizontal splitting ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
