skytin1004 commented on PR #719: URL: https://github.com/apache/fesod/pull/719#issuecomment-4397456427
Hi @ongdisheng, @delei I was looking through #719 and tried reproducing the original "WriteCellData(Date)" issue locally. It feels like the PR has grown a bit beyond the original "java.sql.Date" / "java.sql.Time" "toInstant()" problem. Do you think it would be easier to review this in smaller pieces first starting with the constructor behavior and a few focused regression tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
