GOODBOY008 opened a new pull request, #901: URL: https://github.com/apache/fesod/pull/901
## Summary Implements Phase 1-2 of the test modernization proposal from issue #717. ## Changes ### New Testkit Infrastructure (`testkit/` package) - `AbstractExcelTest` — base class with format providers and temp file management - `ExcelFormat` enum — XLSX/XLS/CSV with capability metadata - `CollectingReadListener` — reusable data collector without embedded assertions - `ExcelAssertions` — fluent Excel file assertions via AssertJ ### Parameterized Tests (JUnit 5) - Replace 3 nearly identical per-format test methods with a single `@ParameterizedTest` - Automatic format coverage: XLSX, XLS, and CSV in one method ### Separation of Concerns - Remove listener classes that embed `Assertions.*` calls (SRP violation) - Move all assertions into test methods ### Package Reorganization - Consolidate legacy scattered packages into `core/`, `format/`, `readwrite/`, `sheet/`, `style/` - Merge near-duplicate model classes ## Metrics | | Before | After | |---|---|---| | Listener Classes | 25+ | 1 | | Per-format test methods | 3x | 1x (parameterized) | ## Related Closes #717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
