skytin1004 commented on issue #878: URL: https://github.com/apache/fesod/issues/878#issuecomment-4245020522
Hi @psxjoy, I took a closer look at `fesod-examples/fesod-sheet-examples`. I scanned all 63 Java files in this module and found: 34 files with ASF + Alibaba headers 29 files with ASF-only headers 0 files with missing ASF headers Among the ASF-only files, I found 5 files that seem to have git history corresponding to legacy `EasyExcel examples/tests`, so they may still require Alibaba attribution: BasicWriteExample.java (`WriteTest.simpleWrite()`) StyleWriteExample.java (`WriteTest.annotationStyleWrite()`) BasicReadExample.java (`ReadTest.simpleRead()`) ConverterReadExample.java (`ReadTest.converterRead()`) IndexOrNameReadExample.java (`ReadTest.indexOrNameRead()`) From what I saw in the git history and PR #888, these 5 files look like they may be derived from EasyExcel. The rest of the ASF-only files (like those in util, test, and advanced) seem to be newly written in Fesod. Could you please help confirm whether these 5 files should also keep Alibaba attribution? If so, I'd be happy to prepare a follow-up patch for them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
