gianm commented on code in PR #20607:
URL: https://github.com/apache/druid/pull/20607#discussion_r4366401218
##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -817,11 +817,16 @@ VirtualColumns computeVirtualColumns(final boolean
includeDimensions)
* Returns a pair of DataSource and Filtration object created on the query
filter. In case the data source is
* a join datasource, the datasource may be altered and left filter of join
datasource may
* be rid of time filters.
+ *
+ * @param timeCondition intervals to AND with the filtration intervals if
the datasource is table-based, from
+ * {@link PlannerContext#getTimeCondition()}. Must be
sorted and non-overlapping. Null means
+ * no additional condition.
*/
@VisibleForTesting
static Pair<DataSource, Filtration> getFiltration(
DataSource dataSource,
DimFilter filter,
+ @Nullable List<Interval> timeCondition,
Review Comment:
I tried folding it into the filter, it seems to work well enough so I pushed
that up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
